-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new pet chicken #339
Merged
Merged
Add new pet chicken #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure you're running a newer version of vs code. Also open up the Developer Console to see any runtime errors |
Love your chicken names list, 'Albert Eggstein' 😂 this is masterpiece 🤌🏼 |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 16.35% 14.34% -2.01%
==========================================
Files 18 17 -1
Lines 1107 774 -333
Branches 152 103 -49
==========================================
- Hits 181 111 -70
+ Misses 917 663 -254
+ Partials 9 0 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonybaloney
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is connected to issue #242
I changed all necessary things. (or at least I think that I have done this) I tested it and the extension creates the chicken, but it does not get displayed in the frame. Now I don't really know what to do anymore to get it working. :/
Additionally I get errors from the translation files, but I guess, that this has nothing to do with the new chicken-pet.